Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for code formatting #3162

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fixes for code formatting #3162

merged 2 commits into from
Dec 12, 2024

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Dec 10, 2024

Fix the code for changes in code formatting rules.

Copy link

github-actions bot commented Dec 10, 2024

@github-actions github-actions bot temporarily deployed to pull request December 10, 2024 23:12 Inactive
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 75.62500% with 78 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (3a6ce9d) to head (115cdf5).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/Chat/ChatMessages/ChatMessages.tsx 53.33% 5 Missing and 9 partials ⚠️
...Messages/ConversationHeader/ConversationHeader.tsx 50.00% 3 Missing and 1 partial ⚠️
...ntainers/InteractiveMessage/InteractiveMessage.tsx 69.23% 2 Missing and 2 partials ⚠️
src/containers/SettingList/SettingList.tsx 20.00% 0 Missing and 4 partials ⚠️
src/containers/Template/Form/Template.tsx 71.42% 3 Missing and 1 partial ⚠️
...c/routes/AuthenticatedRoute/AuthenticatedRoute.tsx 33.33% 2 Missing and 2 partials ⚠️
...tainers/Chat/ChatSubscription/ChatSubscription.tsx 62.50% 2 Missing and 1 partial ⚠️
src/containers/List/List.tsx 70.00% 2 Missing and 1 partial ⚠️
...c/containers/WaGroups/GroupMessageSubscription.tsx 62.50% 2 Missing and 1 partial ⚠️
src/components/UI/Form/EmojiInput/Editor.tsx 50.00% 2 Missing ⚠️
... and 27 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3162   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files         329      329           
  Lines       10564    10469   -95     
  Branches     2235     2184   -51     
=======================================
- Hits         8630     8553   -77     
+ Misses       1319     1306   -13     
+ Partials      615      610    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kurund kurund requested a review from akanshaaa19 December 10, 2024 23:16
Copy link

cypress bot commented Dec 10, 2024

Glific    Run #5456

Run Properties:  status check passed Passed #5456  •  git commit 76ddb818b3 ℹ️: Merge 115cdf5e1ad3df0b8f7d4a9b855f4bde453337a0 into 3a6ce9d91fb91ef001ed698affd3...
Project Glific
Branch Review code-formatting
Run status status check passed Passed #5456
Run duration 25m 25s
Commit git commit 76ddb818b3 ℹ️: Merge 115cdf5e1ad3df0b8f7d4a9b855f4bde453337a0 into 3a6ce9d91fb91ef001ed698affd3...
Committer Kurund Jalmi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request December 12, 2024 11:36 Inactive
@akanshaaa19 akanshaaa19 merged commit 3e5857e into master Dec 12, 2024
11 of 13 checks passed
@akanshaaa19 akanshaaa19 deleted the code-formatting branch December 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants