Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed whats new link #3144

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Removed whats new link #3144

merged 2 commits into from
Nov 25, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Nov 25, 2024

Commenting out whats new link for now because it points out to an old blog

Copy link

github-actions bot commented Nov 25, 2024

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 08:07 Inactive
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (c4ae135) to head (28b6cb0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
+ Coverage   81.52%   81.55%   +0.02%     
==========================================
  Files         329      329              
  Lines       10556    10556              
  Branches     2233     2233              
==========================================
+ Hits         8606     8609       +3     
+ Misses       1332     1330       -2     
+ Partials      618      617       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund November 25, 2024 08:11
Copy link

cypress bot commented Nov 25, 2024

Glific    Run #5409

Run Properties:  status check passed Passed #5409  •  git commit b3abcbe832 ℹ️: Merge 7c327684440950520474344a8cccf7e257a8352c into 78d8b5584c7025d3c60c0c49cc41...
Project Glific
Branch Review removing-link
Run status status check passed Passed #5409
Run duration 25m 23s
Commit git commit b3abcbe832 ℹ️: Merge 7c327684440950520474344a8cccf7e257a8352c into 78d8b5584c7025d3c60c0c49cc41...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@kurund kurund merged commit d041350 into master Nov 25, 2024
6 of 8 checks passed
@kurund kurund deleted the removing-link branch November 25, 2024 23:30
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 23:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants