-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to pin/unpin flows from the flows list #3137
Conversation
🚀 Deployed on https://deploy-preview-3137--glific-frontend.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3137 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 329 329
Lines 10544 10555 +11
Branches 2233 2233
=======================================
+ Hits 8599 8608 +9
- Misses 1329 1330 +1
- Partials 616 617 +1 ☔ View full report in Codecov by Sentry. |
Glific Run #5398
Run Properties:
|
Project |
Glific
|
Branch Review |
enhancement/pin-flows
|
Run status |
Passed #5398
|
Run duration | 24m 43s |
Commit |
d6b695651d ℹ️: Merge 6d8b311807da6a635c2cb9c1cb8ab351a79a46a1 into ec8a274f7937743f813a9bc02479...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
Glific Run #5413
Run Properties:
|
Project |
Glific
|
Branch Review |
enhancement/pin-flows
|
Run status |
Passed #5413
|
Run duration | 25m 45s |
Commit |
bc4bc69017 ℹ️: Merge c1c9ff5f3af2a8593b7639ff06ad20f324f03ef0 into 78d8b5584c7025d3c60c0c49cc41...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality is working as expected. However, refresh action works only once. Can you fix the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
target issue is #3132