Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to pin/unpin flows from the flows list #3137

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3132

@akanshaaa19 akanshaaa19 self-assigned this Nov 21, 2024
@akanshaaa19 akanshaaa19 linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 21, 2024

@github-actions github-actions bot temporarily deployed to pull request November 21, 2024 03:37 Inactive
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (78d8b55) to head (c1c9ff5).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3137   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files         329      329           
  Lines       10544    10555   +11     
  Branches     2233     2233           
=======================================
+ Hits         8599     8608    +9     
- Misses       1329     1330    +1     
- Partials      616      617    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 21, 2024

Glific    Run #5398

Run Properties:  status check passed Passed #5398  •  git commit d6b695651d ℹ️: Merge 6d8b311807da6a635c2cb9c1cb8ab351a79a46a1 into ec8a274f7937743f813a9bc02479...
Project Glific
Branch Review enhancement/pin-flows
Run status status check passed Passed #5398
Run duration 24m 43s
Commit git commit d6b695651d ℹ️: Merge 6d8b311807da6a635c2cb9c1cb8ab351a79a46a1 into ec8a274f7937743f813a9bc02479...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Nov 21, 2024

Glific    Run #5413

Run Properties:  status check passed Passed #5413  •  git commit bc4bc69017 ℹ️: Merge c1c9ff5f3af2a8593b7639ff06ad20f324f03ef0 into 78d8b5584c7025d3c60c0c49cc41...
Project Glific
Branch Review enhancement/pin-flows
Run status status check passed Passed #5413
Run duration 25m 45s
Commit git commit bc4bc69017 ℹ️: Merge c1c9ff5f3af2a8593b7639ff06ad20f324f03ef0 into 78d8b5584c7025d3c60c0c49cc41...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 requested a review from kurund November 21, 2024 04:18
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

Functionality is working as expected. However, refresh action works only once. Can you fix the same.

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 10:00 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 25, 2024 10:46
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kurund kurund merged commit 87c2bf8 into master Nov 25, 2024
12 checks passed
@kurund kurund deleted the enhancement/pin-flows branch November 25, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow: No way to pin/unpin a flow from the list page
2 participants