Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search ui feedback #3130

Merged
merged 10 commits into from
Nov 20, 2024
Merged

File search ui feedback #3130

merged 10 commits into from
Nov 20, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Nov 13, 2024

  • When changing the temperature variable, then trying to save is giving this error. For any value other than 1 is giving this error.
image
  • Changed the error message for deleting an assistant

Product team feedback: https://docs.google.com/document/d/1Erw3Dc_r7OKxlndu3KKCcKqggA5JPp8d8ym3ANsX8dE/edit?tab=t.0#bookmark=id.690f0ro43qck

@akanshaaa19 akanshaaa19 self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 05:22 Inactive
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (5974bf1) to head (6c40eda).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...s/Assistants/AssistantOptions/AssistantOptions.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
- Coverage   81.71%   81.69%   -0.02%     
==========================================
  Files         328      328              
  Lines       10477    10484       +7     
  Branches     2220     2222       +2     
==========================================
+ Hits         8561     8565       +4     
- Misses       1303     1305       +2     
- Partials      613      614       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 05:34 Inactive
Copy link

cypress bot commented Nov 13, 2024

Glific    Run #5385

Run Properties:  status check passed Passed #5385  •  git commit e07eb535d5 ℹ️: Merge c14e53b632fa869e6913be053519e6063580cfb7 into 852f39d6ac885142351fae55cdc7...
Project Glific
Branch Review filesearch-feedback
Run status status check passed Passed #5385
Run duration 25m 32s
Commit git commit e07eb535d5 ℹ️: Merge c14e53b632fa869e6913be053519e6063580cfb7 into 852f39d6ac885142351fae55cdc7...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 requested a review from kurund November 14, 2024 04:08
@github-actions github-actions bot temporarily deployed to pull request November 15, 2024 06:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 15, 2024 06:26 Inactive
@kurund
Copy link
Contributor

kurund commented Nov 17, 2024

@akanshaaa19

Can you please update the issue on what you are trying to fix?

@akanshaaa19
Copy link
Member Author

@akanshaaa19

Can you please update the issue on what you are trying to fix?

done

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

Looks good.

I am not sure about the change in the delete message title. I have added a comment in the feedback document. I feel we should change it back to the original as it was consistent with the other delete messages.

Let's chat

@github-actions github-actions bot temporarily deployed to pull request November 19, 2024 22:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2024 08:44 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 20, 2024 09:22
@github-actions github-actions bot temporarily deployed to pull request November 20, 2024 21:53 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good.

@kurund kurund merged commit 14f5355 into master Nov 20, 2024
11 of 13 checks passed
@kurund kurund deleted the filesearch-feedback branch November 20, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants