-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File search ui feedback #3130
File search ui feedback #3130
Conversation
🚀 Deployed on https://deploy-preview-3130--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3130 +/- ##
==========================================
- Coverage 81.71% 81.69% -0.02%
==========================================
Files 328 328
Lines 10477 10484 +7
Branches 2220 2222 +2
==========================================
+ Hits 8561 8565 +4
- Misses 1303 1305 +2
- Partials 613 614 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Glific Run #5385
Run Properties:
|
Project |
Glific
|
Branch Review |
filesearch-feedback
|
Run status |
Passed #5385
|
Run duration | 25m 32s |
Commit |
e07eb535d5 ℹ️: Merge c14e53b632fa869e6913be053519e6063580cfb7 into 852f39d6ac885142351fae55cdc7...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
Can you please update the issue on what you are trying to fix? |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I am not sure about the change in the delete message title. I have added a comment in the feedback document. I feel we should change it back to the original as it was consistent with the other delete messages.
Let's chat
…nd into filesearch-feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good.
Product team feedback: https://docs.google.com/document/d/1Erw3Dc_r7OKxlndu3KKCcKqggA5JPp8d8ym3ANsX8dE/edit?tab=t.0#bookmark=id.690f0ro43qck