Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more details to logs #3107

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Added more details to logs #3107

merged 3 commits into from
Oct 5, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

Copy link

github-actions bot commented Oct 4, 2024

@github-actions github-actions bot temporarily deployed to pull request October 4, 2024 08:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 4, 2024 08:49 Inactive
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (1cb80f7) to head (69a8f02).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/config/logs.ts 0.00% 4 Missing ⚠️
src/config/apolloclient.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.02%     
==========================================
  Files         323      323              
  Lines       10349    10351       +2     
  Branches     2198     2198              
==========================================
  Hits         8382     8382              
- Misses       1338     1340       +2     
  Partials      629      629              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund October 4, 2024 09:06
@github-actions github-actions bot temporarily deployed to pull request October 4, 2024 09:08 Inactive
Copy link

cypress bot commented Oct 4, 2024

Glific    Run #5313

Run Properties:  status check passed Passed #5313  •  git commit 37e93672f8 ℹ️: Merge 69a8f027f2dee4fbfa9781738edb596790f91207 into 1cb80f7a125b17d938c9dd41f40d...
Project Glific
Branch Review enhancement/adding-logs
Run status status check passed Passed #5313
Run duration 26m 21s
Commit git commit 37e93672f8 ℹ️: Merge 69a8f027f2dee4fbfa9781738edb596790f91207 into 1cb80f7a125b17d938c9dd41f40d...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kurund kurund merged commit 6995de4 into master Oct 5, 2024
10 of 13 checks passed
@kurund kurund deleted the enhancement/adding-logs branch October 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants