Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unable to find contacts in add to collection #3100

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

akanshaaa19
Copy link
Member

target issue is #3097

@akanshaaa19 akanshaaa19 self-assigned this Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 15:52 Inactive
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (7523e69) to head (cfcb973).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
- Coverage   80.94%   80.90%   -0.04%     
==========================================
  Files         323      323              
  Lines       10378    10353      -25     
  Branches     2206     2200       -6     
==========================================
- Hits         8400     8376      -24     
  Misses       1344     1344              
+ Partials      634      633       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 16:02 Inactive
Copy link

cypress bot commented Sep 26, 2024

Glific    Run #5286

Run Properties:  status check passed Passed #5286  •  git commit 1702bf6d99 ℹ️: Merge cfcb973454a1529cec1ea3d1beb1468d5e61ece6 into 7523e69f9b882110c49f1487e33e...
Project Glific
Branch Review fix/contacts-add
Run status status check passed Passed #5286
Run duration 24m 53s
Commit git commit 1702bf6d99 ℹ️: Merge cfcb973454a1529cec1ea3d1beb1468d5e61ece6 into 7523e69f9b882110c49f1487e33e...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 requested a review from kurund September 27, 2024 10:36
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kurund kurund merged commit 6998192 into master Sep 27, 2024
11 of 13 checks passed
@kurund kurund deleted the fix/contacts-add branch September 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants