Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for file search #3089

Closed
wants to merge 16 commits into from
Closed

UI for file search #3089

wants to merge 16 commits into from

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Sep 17, 2024

Master issue is: #3038
Design file

  • Add side menu
  • Assistants List
  • Assistant creation page
  • Storage list
  • Storage creation page
  • Connecting APIs
  • Test cases and clean up

Copy link

github-actions bot commented Sep 17, 2024

@github-actions github-actions bot temporarily deployed to pull request September 17, 2024 06:18 Inactive
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 79.55801% with 37 lines in your changes missing coverage. Please review.

Project coverage is 80.97%. Comparing base (1cb80f7) to head (c86c3c2).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...lkit/Assistant/CreateAssistant/CreateAssistant.tsx 0.00% 13 Missing ⚠️
...it/Assistant/AssistantOptions/AssistantOptions.tsx 0.00% 8 Missing ⚠️
src/containers/AIToolkit/ListItems/List.tsx 81.48% 1 Missing and 4 partials ⚠️
...ners/AIToolkit/Assistant/Assistants/Assistants.tsx 0.00% 4 Missing ⚠️
...IToolkit/Storage/Assistants/AssistantsAttached.tsx 71.42% 2 Missing and 2 partials ⚠️
src/containers/AIToolkit/Storage/Files/Files.tsx 93.93% 0 Missing and 2 partials ⚠️
src/components/UI/HelpIcon/HelpIcon.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
- Coverage   80.99%   80.97%   -0.03%     
==========================================
  Files         323      339      +16     
  Lines       10349    10527     +178     
  Branches     2198     2229      +31     
==========================================
+ Hits         8382     8524     +142     
- Misses       1338     1366      +28     
- Partials      629      637       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 17, 2024

Glific    Run #5310

Run Properties:  status check passed Passed #5310  •  git commit 987592b953 ℹ️: Merge c86c3c27bfa0bd9effd6f1fccf2e0c6830eedece into 1cb80f7a125b17d938c9dd41f40d...
Project Glific
Branch Review feature/filesearch-ui
Run status status check passed Passed #5310
Run duration 27m 18s
Commit git commit 987592b953 ℹ️: Merge c86c3c27bfa0bd9effd6f1fccf2e0c6830eedece into 1cb80f7a125b17d938c9dd41f40d...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request September 20, 2024 10:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 12:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 08:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 3, 2024 08:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 3, 2024 09:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 3, 2024 10:13 Inactive
@akanshaaa19
Copy link
Member Author

closing this PR because of the new changes, new PR

@akanshaaa19 akanshaaa19 deleted the feature/filesearch-ui branch October 17, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master issue for OpenAI Filesearch GPT Filesearch: Adding UI support
1 participant