Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed loading state on clicking cancel #3086

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Removed loading state on clicking cancel #3086

merged 3 commits into from
Sep 16, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3080

@akanshaaa19 akanshaaa19 self-assigned this Sep 12, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 12, 2024

@github-actions github-actions bot temporarily deployed to pull request September 12, 2024 14:45 Inactive
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (f1958a8) to head (e0e7d23).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
- Coverage   86.15%   86.14%   -0.01%     
==========================================
  Files         323      323              
  Lines       10405    10406       +1     
  Branches     2217     2217              
==========================================
  Hits         8964     8964              
- Misses       1338     1339       +1     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 12, 2024

Glific    Run #5256

Run Properties:  status check passed Passed #5256  •  git commit 95d1424bcc ℹ️: Merge e0e7d23287dbcd5a3d082fe6396b9f83d486a399 into f1958a89a7288d3a08c9f5a67a5b...
Project Glific
Branch Review fix/maytapi-dialog
Run status status check passed Passed #5256
Run duration 24m 20s
Commit git commit 95d1424bcc ℹ️: Merge e0e7d23287dbcd5a3d082fe6396b9f83d486a399 into f1958a89a7288d3a08c9f5a67a5b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 changed the title removed loading state on cancel Removed loading state on clicking cancel Sep 12, 2024
@akanshaaa19 akanshaaa19 requested a review from kurund September 12, 2024 16:25
@github-actions github-actions bot temporarily deployed to pull request September 12, 2024 16:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 13, 2024 08:22 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kurund kurund merged commit 2c8b23d into master Sep 16, 2024
12 of 13 checks passed
@kurund kurund deleted the fix/maytapi-dialog branch September 16, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button is in loading state even on clicking cancel
2 participants