-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed loading state on clicking cancel #3086
Conversation
🚀 Deployed on https://deploy-preview-3086--glific-frontend.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3086 +/- ##
==========================================
- Coverage 86.15% 86.14% -0.01%
==========================================
Files 323 323
Lines 10405 10406 +1
Branches 2217 2217
==========================================
Hits 8964 8964
- Misses 1338 1339 +1
Partials 103 103 ☔ View full report in Codecov by Sentry. |
Glific Run #5256
Run Properties:
|
Project |
Glific
|
Branch Review |
fix/maytapi-dialog
|
Run status |
Passed #5256
|
Run duration | 24m 20s |
Commit |
95d1424bcc ℹ️: Merge e0e7d23287dbcd5a3d082fe6396b9f83d486a399 into f1958a89a7288d3a08c9f5a67a5b...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
target issue is #3080