Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made contact name consistent in collection list #3085

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

akanshaaa19
Copy link
Member

target issue is #3082

Copy link

github-actions bot commented Sep 12, 2024

@github-actions github-actions bot temporarily deployed to pull request September 12, 2024 14:41 Inactive
@akanshaaa19 akanshaaa19 self-assigned this Sep 12, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (2c8b23d) to head (aaf02fa).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3085      +/-   ##
==========================================
+ Coverage   86.14%   86.15%   +0.01%     
==========================================
  Files         323      323              
  Lines       10406    10410       +4     
  Branches     2217     2218       +1     
==========================================
+ Hits         8964     8969       +5     
+ Misses       1339     1338       -1     
  Partials      103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 12, 2024

Glific    Run #5257

Run Properties:  status check passed Passed #5257  •  git commit 54045c7ff7 ℹ️: Merge befb1f19821f1208747c44750856341f85d2e7e2 into f1958a89a7288d3a08c9f5a67a5b...
Project Glific
Branch Review contact-names
Run status status check passed Passed #5257
Run duration 24m 27s
Commit git commit 54045c7ff7 ℹ️: Merge befb1f19821f1208747c44750856341f85d2e7e2 into f1958a89a7288d3a08c9f5a67a5b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 requested a review from kurund September 12, 2024 16:13
@github-actions github-actions bot temporarily deployed to pull request September 13, 2024 04:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 13, 2024 16:02 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 22:02 Inactive
@kurund kurund merged commit 6fb541f into master Sep 24, 2024
10 of 11 checks passed
@kurund kurund deleted the contact-names branch September 24, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different names in collections list
2 participants