-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Separating HSM and Speed sends #3063
base: master
Are you sure you want to change the base?
Conversation
🚀 Deployed on https://deploy-preview-3063--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3063 +/- ##
==========================================
+ Coverage 81.64% 81.77% +0.12%
==========================================
Files 330 326 -4
Lines 10494 10511 +17
Branches 2192 2174 -18
==========================================
+ Hits 8568 8595 +27
+ Misses 1312 1301 -11
- Partials 614 615 +1 ☔ View full report in Codecov by Sentry. |
Glific Run #5478
Run Properties:
|
Project |
Glific
|
Branch Review |
templates-refactoring
|
Run status |
Passed #5478
|
Run duration | 26m 03s |
Commit |
49cc62c1e8 ℹ️: Merge 910ea99913f161da4f2f4f0bfa2caf6b1ac95323 into 9297c0b157699d9e7d9ec79a7ac3...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
172
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also refactor listing screens.
Let's discuss over the call.
@@ -22,7 +22,7 @@ import { GroupCollectionList } from 'containers/WaGroups/GroupCollections/GroupC | |||
const Chat = lazy(() => import('containers/Chat/Chat')); | |||
const Layout = lazy(() => import('components/UI/Layout/Layout')); | |||
const SpeedSendList = lazy(() => import('containers/Template/List/SpeedSendList/SpeedSendList')); | |||
const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSend/SpeedSend')); | |||
const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSends/SpeedSends')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible let's avoid fodder and file renaming.
…tend into templates-refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the conflicts whenever you have some time?
No description provided.