Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Separating HSM and Speed sends #3063

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

akanshaaa19
Copy link
Member

No description provided.

@akanshaaa19 akanshaaa19 added the enhancement New feature or request label Sep 4, 2024
@akanshaaa19 akanshaaa19 self-assigned this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

@github-actions github-actions bot temporarily deployed to pull request September 4, 2024 18:17 Inactive
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 77.63975% with 144 lines in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (9297c0b) to head (910ea99).

Files with missing lines Patch % Lines
src/containers/HSM/HSM.tsx 81.37% 34 Missing and 23 partials ⚠️
src/containers/SpeedSend/SpeedSend.tsx 73.50% 33 Missing and 20 partials ⚠️
src/containers/HSM/HSMList/HSMList.tsx 63.63% 18 Missing and 6 partials ⚠️
...ntainers/SpeedSend/SpeedSendList/SpeedSendList.tsx 78.94% 6 Missing and 2 partials ⚠️
src/mocks/Template.tsx 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3063      +/-   ##
==========================================
+ Coverage   81.64%   81.77%   +0.12%     
==========================================
  Files         330      326       -4     
  Lines       10494    10511      +17     
  Branches     2192     2174      -18     
==========================================
+ Hits         8568     8595      +27     
+ Misses       1312     1301      -11     
- Partials      614      615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 4, 2024

Glific    Run #5478

Run Properties:  status check passed Passed #5478  •  git commit 49cc62c1e8 ℹ️: Merge 910ea99913f161da4f2f4f0bfa2caf6b1ac95323 into 9297c0b157699d9e7d9ec79a7ac3...
Project Glific
Branch Review templates-refactoring
Run status status check passed Passed #5478
Run duration 26m 03s
Commit git commit 49cc62c1e8 ℹ️: Merge 910ea99913f161da4f2f4f0bfa2caf6b1ac95323 into 9297c0b157699d9e7d9ec79a7ac3...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request September 20, 2024 18:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 21, 2024 04:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 23, 2024 16:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 17:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 18:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 18:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 18:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 18:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 05:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 29, 2024 06:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 2, 2024 04:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 8, 2024 17:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 8, 2024 18:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 9, 2024 05:57 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund October 9, 2024 06:02
@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 10:04 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also refactor listing screens.

Let's discuss over the call.

@@ -22,7 +22,7 @@ import { GroupCollectionList } from 'containers/WaGroups/GroupCollections/GroupC
const Chat = lazy(() => import('containers/Chat/Chat'));
const Layout = lazy(() => import('components/UI/Layout/Layout'));
const SpeedSendList = lazy(() => import('containers/Template/List/SpeedSendList/SpeedSendList'));
const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSend/SpeedSend'));
const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSends/SpeedSends'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

If possible let's avoid fodder and file renaming.

@akanshaaa19 akanshaaa19 requested a review from kurund October 16, 2024 08:02
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 15:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 03:46 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflicts whenever you have some time?

@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 04:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 18, 2024 07:21 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund December 18, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants