Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed copy in hsm #3056

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fixed copy in hsm #3056

merged 2 commits into from
Sep 3, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3005

@akanshaaa19 akanshaaa19 self-assigned this Sep 3, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 3, 2024

@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 17:48 Inactive
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (97bfd7f) to head (e9a40b1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/Template/Form/Template.tsx 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3056      +/-   ##
==========================================
- Coverage   80.11%   80.10%   -0.01%     
==========================================
  Files         322      322              
  Lines       10368    10371       +3     
  Branches     2209     2211       +2     
==========================================
+ Hits         8306     8308       +2     
- Misses       1418     1419       +1     
  Partials      644      644              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 3, 2024

Glific    Run #5166

Run Properties:  status check failed Failed #5166  •  git commit f3326c8657 ℹ️: Merge f77780be4040aa6f9e11ae5547de5aa9b23d771e into 7584cb043a2b95cfc8c45a2fd63b...
Project Glific
Branch Review fix/copy
Run status status check failed Failed #5166
Run duration 25m 55s
Commit git commit f3326c8657 ℹ️: Merge f77780be4040aa6f9e11ae5547de5aa9b23d771e into 7584cb043a2b95cfc8c45a2fd63b...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 168
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/trigger/Trigger.spec.ts • 1 failed test

View Output

Test Artifacts
Triggers (daily) > should create new trigger Test Replay Screenshots

@akanshaaa19 akanshaaa19 requested a review from kurund September 3, 2024 18:33
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 21:41 Inactive
@kurund kurund merged commit 5e4e6dc into master Sep 3, 2024
10 of 13 checks passed
@kurund kurund deleted the fix/copy branch September 3, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM Template: copy is not working
2 participants