-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates copy #2618
Templates copy #2618
Conversation
3 failed and 1 flaky tests on run #3787 ↗︎
Details:
roles/staff/chat/Chat.spec.ts • 1 failed test
template/SpeedSend.spec.ts • 2 failed tests
cypress/e2e/staffmanagement/StaffManagement.spec.ts • 1 flaky test
Review all test suite changes for PR #2618 ↗︎ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
+ Coverage 73.16% 73.19% +0.03%
==========================================
Files 242 242
Lines 8459 8454 -5
Branches 1803 1795 -8
==========================================
- Hits 6189 6188 -1
+ Misses 1663 1662 -1
+ Partials 607 604 -3 ☔ View full report in Codecov by Sentry. |
Unit tests are working fine on my local. It's failing due to an error specific to CI which you mentioned during our call. Cypress error is fixed in glific/cypress-testing#167 We would also need to update the CI on the frontend after we merge this and Cypress PR. I can do that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code looks good.
When I copy a template I am not able to edit it. Ideally after copy I should be able to edit it.
This should be fixed. |
Fixes for #2420