Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates copy #2618

Merged
merged 18 commits into from
Dec 3, 2023
Merged

Templates copy #2618

merged 18 commits into from
Dec 3, 2023

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Nov 14, 2023

Fixes for #2420

Copy link

github-actions bot commented Nov 14, 2023

@github-actions github-actions bot temporarily deployed to pull request November 14, 2023 23:22 Inactive
Copy link

cypress bot commented Nov 14, 2023

3 failed and 1 flaky tests on run #3787 ↗︎

3 172 0 0 Flakiness 1

Details:

Merge a50f003 into 34ef64c...
Project: Glific Commit: 66f3cb596e ℹ️
Status: Failed Duration: 24:10 💡
Started: Nov 29, 2023 12:44 AM Ended: Nov 29, 2023 1:08 AM
Failed  roles/staff/chat/Chat.spec.ts • 1 failed test

View Output

Test Artifacts
Role - Staff - Chats > should go to top Screenshots
Failed  template/SpeedSend.spec.ts • 2 failed tests

View Output

Test Artifacts
Speed Send > should edit speed send Screenshots
Speed Send > should show all languages Screenshots
Flakiness  cypress/e2e/staffmanagement/StaffManagement.spec.ts • 1 flaky test

View Output

Test Artifacts
Staff Management > should delete collection Screenshots

Review all test suite changes for PR #2618 ↗︎

@github-actions github-actions bot temporarily deployed to pull request November 17, 2023 00:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 23, 2023 22:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 24, 2023 23:51 Inactive
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (08e6b9b) 73.16% compared to head (a50f003) 73.19%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/containers/Template/Form/Template.tsx 47.43% 33 Missing and 8 partials ⚠️
src/containers/Template/List/Template.tsx 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
+ Coverage   73.16%   73.19%   +0.03%     
==========================================
  Files         242      242              
  Lines        8459     8454       -5     
  Branches     1803     1795       -8     
==========================================
- Hits         6189     6188       -1     
+ Misses       1663     1662       -1     
+ Partials      607      604       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 24, 2023 23:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 25, 2023 00:21 Inactive
@kurund kurund requested a review from mdshamoon November 25, 2023 23:25
@kurund
Copy link
Contributor Author

kurund commented Nov 25, 2023

@mdshamoon

Unit tests are working fine on my local. It's failing due to an error specific to CI which you mentioned during our call.

Cypress error is fixed in glific/cypress-testing#167

We would also need to update the CI on the frontend after we merge this and Cypress PR. I can do that later.

Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code looks good.
When I copy a template I am not able to edit it. Ideally after copy I should be able to edit it.

@github-actions github-actions bot temporarily deployed to pull request November 29, 2023 00:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 29, 2023 00:24 Inactive
@kurund
Copy link
Contributor Author

kurund commented Nov 29, 2023

When I copy a template I am not able to edit it. Ideally after copy I should be able to edit it.

This should be fixed.

@github-actions github-actions bot temporarily deployed to pull request November 29, 2023 00:36 Inactive
@mdshamoon mdshamoon merged commit 1f7f959 into master Dec 3, 2023
9 of 12 checks passed
@mdshamoon mdshamoon deleted the templates-copy branch December 3, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants