Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticketing updates #2610

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Ticketing updates #2610

merged 3 commits into from
Nov 2, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Ticketing updates

Copy link

github-actions bot commented Nov 2, 2023

@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 03:58 Inactive
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be162cd) 73.26% compared to head (ddfece1) 73.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2610      +/-   ##
==========================================
+ Coverage   73.26%   73.34%   +0.08%     
==========================================
  Files         241      241              
  Lines        8422     8423       +1     
  Branches     1796     1796              
==========================================
+ Hits         6170     6178       +8     
+ Misses       1646     1642       -4     
+ Partials      606      603       -3     
Files Coverage Δ
src/containers/Ticket/TicketList/TicketList.tsx 69.76% <100.00%> (+0.71%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 2, 2023

2 failed and 2 flaky tests on run #3743 ↗︎

2 173 0 0 Flakiness 2

Details:

Merge c8771a5 into be162cd...
Project: Glific Commit: 97208b0b2f ℹ️
Status: Failed Duration: 24:25 💡
Started: Nov 2, 2023 7:00 AM Ended: Nov 2, 2023 7:24 AM
Failed  flow/FlowEditor.spec.ts • 1 failed test

View Output Video

Test Artifacts
Flow > should configure Flow Output Screenshots
Failed  roles/staff/chat/Chat.spec.ts • 1 failed test

View Output Video

Test Artifacts
Role - Staff - Chats > should send the templates Output Screenshots
Flakiness  roles/staff/chat/Chat.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Role - Staff - Chats > should go to top Output Screenshots
Flakiness  staffmanagement/StaffManagement.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Staff Management > should redirect to staff management page Output Screenshots

Review all test suite changes for PR #2610 ↗︎

@mdshamoon mdshamoon linked an issue Nov 2, 2023 that may be closed by this pull request
@mdshamoon mdshamoon linked an issue Nov 2, 2023 that may be closed by this pull request
@mdshamoon mdshamoon requested a review from kurund November 2, 2023 06:51
@mdshamoon mdshamoon self-assigned this Nov 2, 2023
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 06:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 23:02 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kurund kurund merged commit 57930d5 into master Nov 2, 2023
5 of 6 checks passed
@kurund kurund deleted the ticket/ids branch November 2, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overlap in Ticket Listing Page Ticketing System : Unique IDs for tickets
2 participants