Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added last login fix for gupshup enterprise #2608

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Added last login fix for gupshup enterprise #2608

merged 2 commits into from
Nov 1, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Added last login fix for gupshup enterprise

@mdshamoon mdshamoon requested a review from kurund October 31, 2023 09:01
@mdshamoon mdshamoon linked an issue Oct 31, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 09:03 Inactive
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d6a74ab) 73.30% compared to head (8b1cd3c) 73.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
+ Coverage   73.30%   73.31%   +0.01%     
==========================================
  Files         241      241              
  Lines        8420     8422       +2     
  Branches     1795     1796       +1     
==========================================
+ Hits         6172     6175       +3     
+ Misses       1644     1643       -1     
  Partials      604      604              
Files Coverage Δ
src/containers/LastLogin/LastLogin.tsx 83.33% <50.00%> (-16.67%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 31, 2023

1 flaky test on run #3735 ↗︎

0 175 0 0 Flakiness 1

Details:

Merge bf08ffc into 98b7a1f...
Project: Glific Commit: ac0276e09c ℹ️
Status: Passed Duration: 35:34 💡
Started: Oct 31, 2023 9:14 AM Ended: Oct 31, 2023 9:49 AM
Flakiness  cypress/e2e/collection/Collection.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Collection > should edit collection Output Screenshots

Review all test suite changes for PR #2608 ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 23:44 Inactive
@kurund kurund merged commit 0472af7 into master Nov 1, 2023
5 of 6 checks passed
@kurund kurund deleted the style/login branch November 1, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last login time in gupshup enterprise looks weird
2 participants