Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic name length #2607

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix dynamic name length #2607

merged 1 commit into from
Oct 31, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Fix dynamic name length

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request October 31, 2023 07:04 Inactive
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (98b7a1f) 73.32% compared to head (59f66c3) 73.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
+ Coverage   73.32%   73.34%   +0.02%     
==========================================
  Files         241      241              
  Lines        8419     8420       +1     
  Branches     1799     1795       -4     
==========================================
+ Hits         6173     6176       +3     
  Misses       1642     1642              
+ Partials      604      602       -2     
Files Coverage Δ
src/common/utils.ts 72.11% <100.00%> (+0.54%) ⬆️
...onversations/ChatConversation/ChatConversation.tsx 66.17% <100.00%> (ø)
.../Chat/ChatMessages/AddAttachment/AddAttachment.tsx 68.60% <100.00%> (+1.16%) ⬆️
...ainers/Chat/ChatMessages/ContactBar/ContactBar.tsx 72.61% <ø> (ø)
...rs/WebhookLogs/WebhookLogsList/WebhookLogsList.tsx 81.25% <ø> (+1.65%) ⬆️
.../AdminContactManagement/AdminContactManagement.tsx 23.07% <0.00%> (ø)
...ment/UploadContactsDialog/UploadContactsDialog.tsx 40.74% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 31, 2023

Passing run #3734 ↗︎

0 175 0 0 Flakiness 0

Details:

Merge 59f66c3 into 98b7a1f...
Project: Glific Commit: 760d37c416 ℹ️
Status: Passed Duration: 28:07 💡
Started: Oct 31, 2023 7:13 AM Ended: Oct 31, 2023 7:41 AM

Review all test suite changes for PR #2607 ↗︎

@mdshamoon mdshamoon linked an issue Oct 31, 2023 that may be closed by this pull request
@mdshamoon mdshamoon self-assigned this Oct 31, 2023
@mdshamoon mdshamoon requested a review from kurund October 31, 2023 08:47
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kurund kurund merged commit d6a74ab into master Oct 31, 2023
5 of 6 checks passed
@kurund kurund deleted the bug/dynamic-name branch October 31, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat Screen: UI Breaking
2 participants