Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list on saving a popup for add contact to collection #2589

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Update list on saving a popup for add contact to collection

@mdshamoon mdshamoon self-assigned this Oct 11, 2023
@mdshamoon mdshamoon linked an issue Oct 11, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

@github-actions github-actions bot temporarily deployed to pull request October 11, 2023 05:22 Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9d50b53) 73.32% compared to head (c709199) 73.29%.
Report is 8 commits behind head on master.

❗ Current head c709199 differs from pull request most recent head 824bf32. Consider uploading reports for the commit 824bf32 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
- Coverage   73.32%   73.29%   -0.03%     
==========================================
  Files         241      241              
  Lines        8411     8410       -1     
  Branches     1798     1797       -1     
==========================================
- Hits         6167     6164       -3     
- Misses       1640     1642       +2     
  Partials      604      604              
Files Coverage Δ
src/containers/Flow/FlowList/FlowList.tsx 68.49% <ø> (+0.92%) ⬆️
src/containers/List/List.tsx 80.51% <100.00%> (ø)
...iners/Collection/CollectionList/CollectionList.tsx 65.82% <50.00%> (-0.42%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 11, 2023

Passing run #3679 ↗︎

0 175 0 0 Flakiness 0

Details:

Merge c709199 into 3e42d0e...
Project: Glific Commit: 0891ce2370 ℹ️
Status: Passed Duration: 27:49 💡
Started: Oct 11, 2023 5:31 AM Ended: Oct 11, 2023 5:58 AM

Review all test suite changes for PR #2589 ↗︎

@mdshamoon mdshamoon merged commit ec48281 into master Oct 11, 2023
4 checks passed
@mdshamoon mdshamoon deleted the feature/update-list-on-save branch October 11, 2023 08:57
@github-actions github-actions bot temporarily deployed to pull request October 11, 2023 09:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections: UI Enhancement
1 participant