Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more symbols for password validation #2577

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Added more symbols for password validation

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

@github-actions github-actions bot temporarily deployed to pull request October 5, 2023 04:38 Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (45a4a9c) 73.26% compared to head (2711c7c) 73.22%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
- Coverage   73.26%   73.22%   -0.05%     
==========================================
  Files         240      240              
  Lines        8398     8400       +2     
  Branches     1796     1796              
==========================================
- Hits         6153     6151       -2     
- Misses       1641     1643       +2     
- Partials      604      606       +2     
Files Coverage Δ
src/common/constants.ts 100.00% <100.00%> (ø)
src/containers/Auth/Registration/Registration.tsx 47.61% <ø> (ø)
...ers/Auth/ResetPassword/ResetPasswordConfirmOTP.tsx 57.69% <ø> (ø)
src/containers/MyAccount/MyAccount.tsx 81.15% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 5, 2023

1 flaky test on run #3666 ↗︎

0 175 0 0 Flakiness 1

Details:

Merge 2711c7c into 4787f19...
Project: Glific Commit: 985d67ef68 ℹ️
Status: Passed Duration: 29:12 💡
Started: Oct 5, 2023 4:48 AM Ended: Oct 5, 2023 5:17 AM
Flakiness  cypress/e2e/roles/staff/chat/Chat.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Role - Staff - Chats > should go to top Output Screenshots

Review all test suite changes for PR #2577 ↗︎

@mdshamoon mdshamoon self-assigned this Oct 5, 2023
@mdshamoon mdshamoon merged commit a29006e into master Oct 5, 2023
5 of 6 checks passed
@mdshamoon mdshamoon deleted the fix/password-validation branch October 5, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant