Adding support for glidein to use cvmfsexec in mode 3 when possible #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrathaurs
force-pushed
the
branch_v3_11
branch
from
da8b3f0 to
9fa694e
Compare
namrathaurs
force-pushed
the
branch_v3_11
branch
from
4366607 to
9fa694e
Compare
|
Reopening this in draft mode until the changes are ready for review. |
namrathaurs
force-pushed
the
branch_v3_11
branch
2 times, most recently
from
e5e08c5 to
9734fbf
Compare
- removed print statements used primarily for debugging the code - updated indentation in the code files to remain consistent with other scripts - updated mentions and references for mode 2 with mode 1 to stay consistent with cvmfsexec documentation
- removed the previously existing version of cvmfs setup script since a new version is in place - updated the node validation script based on linting suggestions
mambelli
requested changes
Aug 19, 2023
| : | ||
| if [[ $glidein_cvmfs = required ]]; then | ||
| # if mount CVMFS is not successful, report an error and exit with failure exit code | ||
| echo $? |
There was a problem hiding this comment.
Exit code to stdout before exit? Will always be 0
| elif [[ $glidein_cvmfs = preferred || $glidein_cvmfs = optional ]]; then | ||
| # if mount CVMFS is not successful, report a warning/error in the logs and continue with glidein startup | ||
| # script status must be OK, otherwise the glidein will fail | ||
| echo $? |
There was a problem hiding this comment.
Exit code to stdout? Will always be 0
There was a problem hiding this comment.
remove echo $? will always return a zero because of the previous if condition always evaluating to zero
if wanting to print to stdout, then use echo 0/1
if wanting to capture the exit code of the previous command, this does not capture it. I would have to put that into a variable first and then use
3 tasks
|
Closing this pull request without merging as a new PR (#372) has superseded this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes (additions/modifications) towards enabling the glidein to support the use of cvmfsexec in mode 3 when possible. While this PR primarily encompasses changes pertaining to enabling mode 3 support, it also contains a change to the existing logic for script duplication check.
TODO: Make sure that cvmfsexec is used only if there is a working squid proxy