Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sync-exec instead of execSync, fixes problem with Node 0.12 #53

Merged
merged 1 commit into from
Feb 13, 2015
Merged

use sync-exec instead of execSync, fixes problem with Node 0.12 #53

merged 1 commit into from
Feb 13, 2015

Conversation

marten-seemann
Copy link
Contributor

As suggested in mgutz/execSync#38 (comment), replacing execSync by sync-exec solves a problem occurring with Node 0.12.
Will also fix #52.

@marten-seemann
Copy link
Contributor Author

@mgutz What's the status on that?

@mgutz
Copy link

mgutz commented Feb 13, 2015

I put a notice on execSync project's readme that it is no longer maintained. I advise everyone to use sync-exec instead.

@marten-seemann
Copy link
Contributor Author

Thank you, @mgutz, then I think this PR does exactly as you advised.
@gleero: Is there any reason not to merge this PR?

gleero added a commit that referenced this pull request Feb 13, 2015
use sync-exec instead of execSync, fixes problem with Node 0.12
@gleero gleero merged commit 274e31a into gleero:master Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible execSync problem rendering grunt-favicons unusable
3 participants