According to RFC 3986, uri scheme is mandatory (i.e. non-optional) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not been able to find an implementation of URI parsing where scheme is required in any programming language, and it seems impractical to not be able to parse without a scheme being present. Because of these I don't think we should make it mandatory, even if the RFC would like it to be. |
|
somehow I was sure uri_string:parse did that, but now that I test, "path" just results in a path without a scheme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #523 by making scheme non-optional.
adds two tests, one for overriding scheme, the other including previously commented out TODO failures.
renames several uri.merge tests to double check I understood their purpose.