Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basics/strings/ edits #10

Merged
merged 2 commits into from
Jan 20, 2024
Merged

basics/strings/ edits #10

merged 2 commits into from
Jan 20, 2024

Conversation

scottBowles
Copy link
Contributor

@scottBowles scottBowles commented Jan 20, 2024 •
edited
Loading

Two small suggestions for https://tour.gleam.run/basics/strings/:

  1. In Gleam Strings are written
    "Strings" is lowercase below. Should it be lowercase here?
  2. There isn't an example with an escape string, and it's a little confusing because if you add one inside an io.debug call it shows the backslash and all. I added an io.println call with an escape string and a comment for clarity.

lpil
lpil approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit a6bb176 into gleam-lang:main Jan 20, 2024
1 check passed
@scottBowles
Copy link
Contributor Author

Thank you

Gladly. Thanks for the language I'm enjoying learning it!

@scottBowles scottBowles deleted the basic-strings-edits branch January 20, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottBowles @lpil