Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations warnings from stdlib #62

Closed
wants to merge 1 commit into from
Closed

Fix deprecations warnings from stdlib #62

wants to merge 1 commit into from

Conversation

GearsDatapacks
Copy link
Member

This PR replaces usage of the gleam/regex module with the gleam_regexp package

lpil
lpil reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split the strings using the string module rather than regex please 🙏 One less dep and likely faster.

@lpil lpil closed this Dec 8, 2024
@lpil
Copy link
Member

lpil commented Dec 8, 2024

Thank you

@GearsDatapacks GearsDatapacks deleted the stdlib-deprecations branch December 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GearsDatapacks @lpil