PR feedback

gleam-lang · Mar 19, 2024 · ebd05d6 · ebd05d6
1 parent c266652
commit ebd05d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/gleam/http/request.gleam b/src/gleam/http/request.gleam
@@ -67,9 +67,10 @@ pub fn from_uri(uri: Uri) -> Result(Request(String), Nil) {
 /// If the request does not have that header then `Error(Nil)` is returned.
 ///
 pub fn get_header(request: Request(body), key: String) -> Result(String, Nil) {
+  let lowercased_key = string.lowercase(key)
   use #(_, value) <- result.try(
     list.find(request.headers, fn(header) {
-      string.lowercase(header.0) == string.lowercase(key)
+      string.lowercase(header.0) == lowercased_key
     }),
   )
   Ok(value)

diff --git a/test/gleam/http/request_test.gleam b/test/gleam/http/request_test.gleam
@@ -192,7 +192,7 @@ pub fn get_req_case_insensitive_header_test() {
     )
   }
 
-  let header_key = "GLEAM"
+  let header_key = "gleam"
   let request = make_request([#("ANSWER", "42"), #("GLEAM", "awesome")])
   request
   |> request.get_header(header_key)