Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP8 Union Types #692

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

cseufert
Copy link
Collaborator

This change makes all function & method parameters, return types, and class member variables parse types as a list (array), rather than single items.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 96.055% when pulling 5aed303 on moddengine:php8-union-types into 7c2bbbc on glayzzle:master.

@cseufert
Copy link
Collaborator Author

This should close #656

@cseufert
Copy link
Collaborator Author

I think #693 is more inline with what was proposed in ticket #656

@cseufert cseufert changed the base branch from master to php8 March 24, 2021 10:26
@czosel czosel merged commit 5aed303 into glayzzle:php8 Mar 25, 2021
@cseufert
Copy link
Collaborator Author

I would not merge this and the v2 version

@cseufert
Copy link
Collaborator Author

#693 is a cleaner implementation

@czosel
Copy link
Collaborator

czosel commented Mar 25, 2021

Oh sorry! I’ll revert this one later today.

@czosel
Copy link
Collaborator

czosel commented Mar 25, 2021

I just realized that GitHub shows this MR as merged because #693 actually contains the commits of this MR as well. The git history might not be very clean, but otherwise I think we're good 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants