Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - 8.4 Asymmetric Visibility support #1148

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

genintho
Copy link
Collaborator

@genintho genintho commented Dec 4, 2024

@genintho
Copy link
Collaborator Author

genintho commented Dec 5, 2024

@czosel @cseufert This is work in progress, but I would like to hear your thoughts on the approach.

I tried to create a new token for protected(set) and private(set) but gave up after a bit as I could not find a good spot to do this.

I ended creating an intermediate object to store the various flags as it made things simpler to understand and removes a lot of duplication.

One thing I keep going back and forth is if the AST we create should match 100% the code or if it should match the intent of the code. For example public private(set) is the same as private(set). So do we want the AST to be same in both situation or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant