Fix OuiPopover does not change position on the scroll (opensearch-pro…

…ject#1184) Signed-off-by: Vladimir Komolov <[email protected]> Signed-off-by: Комолов Владимир <[email protected]>
gkottr · Mar 6, 2024 · 4c7aca2 · 4c7aca2
1 parent 543435a
commit 4c7aca2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,7 @@
 - Prevent action buttons of OuiDataGridCell from moving the content ([#1224](https://github.com/opensearch-project/oui/pull/1224))
 - Fix vertical alignment and font weight of breadcrumbs that are buttons or links ([#1232](https://github.com/opensearch-project/oui/pull/1232))
 - Fix datagrid lines ([#1250](https://github.com/opensearch-project/oui/pull/1250))
+- Fix OuiPopover does not change position on the scroll ([#1184](https://github.com/opensearch-project/oui/pull/1184))
 
 ### 🚞 Infrastructure
 

diff --git a/src/components/popover/popover.tsx b/src/components/popover/popover.tsx
@@ -532,7 +532,7 @@ export class OuiPopover extends Component<Props, State> {
  }
 
  if (this.props.repositionOnScroll) {
- window.addEventListener('scroll', this.positionPopoverFixed);
+ window.addEventListener('scroll', this.positionPopoverFixed, true);
  }
  }
 
@@ -545,9 +545,9 @@ export class OuiPopover extends Component<Props, State> {
  // update scroll listener
  if (prevProps.repositionOnScroll !== this.props.repositionOnScroll) {
  if (this.props.repositionOnScroll) {
- window.addEventListener('scroll', this.positionPopoverFixed);
+ window.addEventListener('scroll', this.positionPopoverFixed, true);
  } else {
- window.removeEventListener('scroll', this.positionPopoverFixed);
+ window.removeEventListener('scroll', this.positionPopoverFixed, true);
  }
  }
 
@@ -565,7 +565,7 @@ export class OuiPopover extends Component<Props, State> {
  }
 
  componentWillUnmount() {
- window.removeEventListener('scroll', this.positionPopoverFixed);
+ window.removeEventListener('scroll', this.positionPopoverFixed, true);
  clearTimeout(this.respositionTimeout);
  clearTimeout(this.closingTransitionTimeout);
  cancelAnimationFrame(this.closingTransitionAnimationFrame!);