This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
Support ESKO zae files with texture files as blubs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 4cac36c into 2fc470c - view on LGTM.com fixed alerts:
Warning - Automated code review for gkjohnson/collada-archive-loader-js will be disabled on October 1, 2019. You can avoid this by installing the LGTM.com GitHub App. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
|
Great thanks for the contribution @taltool! Do you mind elaborating on why the current method isn't sufficient? And would you be able to upload an ESKO model so I can understand the difference? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will replace the texture files in the collada file to point to memory based image blub files found in the .zae archive files. The intention of this commit is to easily view ESKO models online via threejs.