This repository has been archived by the owner on Dec 2, 2022. It is now read-only.
Accessibility: missing ALT attribute in course summary images #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the filename as ALT, which seems wrong, but as far as I researched the Moodle code... using Atto for adding an Image, the description is immediately saved as an ALT attribute in the content, but not in the mdl_files DB table. and so, unavailable if we use that image file elsewhere like at the above course summary attached files (and not as links but as images) looks like we need a new accessibility MDL on the tracker. what do you think?
|
I think this is a core issue to address too. |
|
Any other method on the '$file' object? Just seems wrong to correct a mistake with another mistake. |
|
Definitely a core issue. here it is: https://tracker.moodle.org/browse/MDL-52842 |
|
Oh crumbs! With MDL-52842 they have sat on their bums for months and not able to make a decision, now there is a surprise :(. |
gjb2048
force-pushed
the
master
branch
2 times, most recently
from
4de5065 to
5030a95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the filename as ALT, which seems wrong, but as far as I researched the Moodle code... using Atto for adding an Image, the description is immediately saved as an ALT attribute in the content, but not in the mdl_files DB table. and so, unavailable if we use that image file elsewhere like at the above course summary attached files (and not as links but as images) looks like we need a new accessibility MDL on the tracker. what do you think?