fix(temp): block praise in pvt threads #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vyvy-vi
commented
Aug 2, 2023
Vyvy-vi
commented
- This temporarily blocks the usage of praise in private threads (returns an appropriate error message for the user)
- An actual fix that makes praise work in private threads may take a little while.
kristoferlund
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Great! Also, we need to think about this. Should Praise be available in private threads? It seems like a possible privacy issue. Praising someone in a private thread might lead someone to believe that praise stays "private" when in reality it will be posted to the common feed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.