Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3218 - fix bitbucket-server splitPath "scm/" regression #3219

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Coteh
Copy link

@Coteh Coteh commented Apr 6, 2024

Description

As discussed in #3218, this is the fix for the bitbucket-server remote integration, to correctly remove any "scm/" prefixes in the remote links if they're present.

This was originally fixed in #767, but then the following change (ba0a6c8#diff-3df44eca214dcc6e95c893331e04e784c958b3167e664a01dd724acb68cdefefR54) introduced what I believe is a typo in the substringing portion that regressed the behaviour. It should be splitting substrings on transformed path, not the original path.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@Coteh Coteh force-pushed the bitbucket-server-fix branch 3 times, most recently from 7ce1b9c to 457df41 Compare April 6, 2024 22:19
@troopyq
Copy link

troopyq commented Apr 19, 2024

Thanks a lot! I wanted to correct it myself the other day) you’re cool

@Coteh
Copy link
Author

Coteh commented Apr 29, 2024

Hi @eamodio, is it possible you could take a look at this? Thanks!

@bengeisler-syskron
Copy link

It would be great if this PR could be merged. ❤️
I'm also heavily relying on this feature when communicating with my team.

@parthranawat
Copy link

+1 on merging this in. I even tried using regex to fix the /scm issue but it wont work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants