Fix memory leak in CDockContainerWidget::restoreState (#576)

delete old root splitter layout item
githubuser0xFFFF · Nov 4, 2023 · 40beef9 · 40beef9
1 parent 420baee
commit 40beef9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/DockContainerWidget.cpp b/src/DockContainerWidget.cpp
@@ -1932,10 +1932,11 @@ bool CDockContainerWidget::restoreState(CDockingStateReader& s, bool Testing)
 		NewRootSplitter = d->newSplitter(Qt::Horizontal);
 	}
 
-	d->Layout->replaceWidget(d->RootSplitter, NewRootSplitter);
+	QLayoutItem* li = d->Layout->replaceWidget(d->RootSplitter, NewRootSplitter);
 	auto OldRoot = d->RootSplitter;
 	d->RootSplitter = qobject_cast<CDockSplitter*>(NewRootSplitter);
 	OldRoot->deleteLater();
+	delete li;
 
 	return true;
 }