Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: another ghost user error scenario #184

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

zkoppert
Copy link
Member

Pull Request

fixes #173

Proposed Changes

Provide more informative logging and continue instead of exit when error are encountered due to a ghost user. The most important changes include adding try-except blocks to handle potential exceptions and enhancing the error messages to indicate possible causes.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More logging and exception handling ftw. 🎉

@zkoppert zkoppert merged commit d4529df into main Jul 26, 2024
24 checks passed
@zkoppert zkoppert deleted the ghost-user-avatar-error branch July 26, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self.avatar_url = user["avatar_url"] TypeError: 'NoneType' object is not subscriptable
2 participants