Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'context' to mergeDeep name fields #697

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

klutchell
Copy link
Contributor

@klutchell klutchell commented Oct 2, 2024

See: #655

This PR adds a new failing test case for detecting changes to required_status_checks in rulesets.

It then fixes the issue by adding context to the supported named keys in mergeDeep.

This allows mergeDeep to correctly identify
changes to required_status_checks in rulesets

Signed-off-by: Kyle Harding <[email protected]>
@klutchell
Copy link
Contributor Author

@JakubBiel @luvsaxena1 This PR seems to resolve the issue mentioned in this comment: #655 (comment)

@klutchell
Copy link
Contributor Author

@decyjphr can we get this merged please? We've been running this version for a few weeks with no issues.

@decyjphr decyjphr merged commit e059331 into github:main-enterprise Nov 22, 2024
@decyjphr
Copy link
Collaborator

@klutchell thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants