Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization updates #8

Merged
merged 4 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [ '2.4.0', '2.5.0', '2.6.0', '2.7.2', '3.0.0', '3.3.0']
ruby: [ '2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
steps:
- uses: actions/checkout@v2
- name: Set up Ruby ${{ matrix.ruby }}
Expand All @@ -16,10 +16,7 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Build and test with Rake with Ruby ${{ matrix.ruby }}
run: |
gem install bundler
bundle install --jobs 4 --retry 3
bundle exec rake spec
run: bundle exec rake spec
lint:
name: Rubocop
runs-on: ubuntu-latest
Expand All @@ -29,8 +26,6 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
bundler-cache: true
- name: Run linters
run: |
gem install bundler
bundle install --jobs 4 --retry 3
bundle exec rake rubocop
run: bundle exec rake rubocop
2 changes: 1 addition & 1 deletion hackerone-client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
spec.email = ["[email protected]"]

spec.summary = %q{A limited client for the HackerOne API}
spec.homepage = "https://github.com/oreoshake/hackerone-client"
spec.homepage = "https://github.com/github/hackerone-client"
spec.license = "MIT"

spec.files = `git ls-files -z`.split("\x0").reject do |f|
Expand Down
3 changes: 2 additions & 1 deletion lib/hackerone/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

require "faraday"
require "json"
require "active_support/time"
require "active_support"
require "active_support/core_ext/numeric/time"
require_relative "client/version"
require_relative "client/report"
require_relative "client/activity"
Expand Down
6 changes: 3 additions & 3 deletions lib/hackerone/client/program.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ def swag(page_number: 1, page_size: 100)

def balance
response_body = make_get_request(
"programs/#{id}/billing/balance"
)
BillingBalance.new(response_body).balance
"programs/#{id}/billing/balance"
)
BillingBalance.new(response_body).balance
end

private
Expand Down
2 changes: 1 addition & 1 deletion spec/hackerone/client/address_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

RSpec.describe HackerOne::Client::Address do
let (:address_data) do
{
{
name: "Brian Anglin",
street: " 88 Colin P Kelly Jr Street",
city: "San Francisco",
Expand Down
1 change: 0 additions & 1 deletion spec/hackerone/client/attachment_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "spec_helper"
require "active_support/core_ext/hash"

RSpec.describe HackerOne::Client::Attachment do
let (:attachment_data) do
Expand Down
Loading