Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip delete events of changelog table in onChangelogEvent function #1428

Closed
wants to merge 1 commit into from
Closed

skip delete events of changelog table in onChangelogEvent function #1428

wants to merge 1 commit into from

Conversation

whhe
Copy link
Contributor

@whhe whhe commented Jul 1, 2024

A Pull Request should be associated with an Issue.

Related issue: #1427

Description

This PR skip the DELETE events of changelog table in onChangelogEvent function.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@whhe
Copy link
Contributor Author

whhe commented Jul 19, 2024

Replaced by #1434, closed.

@whhe whhe closed this Jul 19, 2024
@whhe whhe deleted the ob-changelog-compatibility branch November 20, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@meiji163 meiji163 Awaiting requested review from meiji163 meiji163 is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whhe