Change opaque ID middleware to not throw OpaqueIDError on 5xx responses #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kag728
previously approved these changes
Jan 23, 2024
ndonewar
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if ES returns a 500 response, we get an
OpaqueIDError(and not theServerError) since we only check for an opaque ID mismatch and don't handle the case when opaque ID is nil.Here I added a check so that the
OpaqueIDErrorwill not be thrown if there is a 5xx response from Elasticsearch, and we will get aElastomerClient::Client::ServerErrorinstead.