Fix RuboCop warnings and default Ruby version #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomthorogood
approved these changes
Dec 5, 2023
Comment on lines
-89
to
+91
| url: url, | ||
| read_timeout: read_timeout, | ||
| open_timeout: open_timeout, | ||
| url:, | ||
| read_timeout:, | ||
| open_timeout:, |
There was a problem hiding this comment.
yay, i love seeing this shorthand ❤️
Comment on lines
-14
to
17
| ruby-version: ['3.0', '3.1', '3.2'] | ||
| ruby-version: ['3.2'] | ||
| ES_VERSION: ['5.6.15', '8.7.0'] | ||
| include: | ||
| - ES_VERSION: '5.6.15' |
There was a problem hiding this comment.
Does this mean that we're no longer supporting 3.0 or 3.1 at all with elastomer client? Will that cause any customer impact, if users are depending upon that support?
There was a problem hiding this comment.
Yeah, since the library is only used internally, we're focusing support on the version we run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes parts of another PR to focus on just the RuboCop fixes needed to get RuboCop in CI working.
.ruby-versionto the latest availablebundle exec rubocop -a).