Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a custom Faraday connection configuration block. #283

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Allow a custom Faraday connection configuration block. #283

merged 4 commits into from
Nov 7, 2023

Conversation

misalcedo
Copy link
Contributor

@misalcedo misalcedo commented Nov 7, 2023 •
edited
Loading

Allow custom configuration of the client's Faraday connection by passing a block to the client's constructor.

Bumped minor version and updated the changelog.

@misalcedo misalcedo marked this pull request as ready for review November 7, 2023 16:11
@C-Ross C-Ross requested review from kag728 and ndonewar November 7, 2023 16:12
ndonewar
ndonewar approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ndonewar ndonewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@misalcedo misalcedo merged commit ec2474b into main Nov 7, 2023
10 checks passed
@misalcedo misalcedo deleted the misalcedo-patch-1 branch November 7, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndonewar ndonewar ndonewar approved these changes

@kag728 kag728 Awaiting requested review from kag728

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misalcedo @ndonewar