-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Windows fixes #369
Bulk Windows fixes #369
Conversation
…indows-fixes-1602277955
…indows-fixes-1602277955
…indows-fixes-1602277955
…thub/docs into bulk-windows-fixes-1602277955
Tested it here on Windows by manually running the workflow: https://github.com/github/docs/runs/1233548947?check_suite_focus=true. The only test that failed was a non-windows specific test on lint-ing so this is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. ✨
Thank you @jeffmcaffer and @chiedo! 💝
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Why:
Shipping numerous work by @jeffmcaffer in bulk to avoid waiting for multiple checks.
This also enables windows tests on github/docs so we can run windows tests against branches here manually.
Closes #351
Closes #348
Closes #319
Closes #312
Closes: #137
Check off the following: