-
Notifications
You must be signed in to change notification settings - Fork 60.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuring-notifications.md to add link for Custom Routing #34903
Conversation
Add link to the Custom Routing URL. Because why follow all the steps when there is a quick link for this.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Note: I think there are more needed edits for this page to match the current UI. However I don't understand how the |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@shadoath Thank you for opening a PR! ✨ Just for context, I wanted to share a link to our style guide regarding user interface elements 💛 If you are proposing this update because the UI isn't quite correct, can you elaborate on the changes you think are needed? |
Hi, I'm afraid we can't accept this contribution— #34903 (comment) already pointed out the style issue with hyperlinks. We don't link to specific parts in the UI from instructional procedures like this. This docs article is designed to be use on a section by section basis and as a reference article, and we already link to the relevant section at the top of the page: In actual fact, the Dependabot settings section you linked to should link to https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications#choosing-your-notification-settings rather than using the wording it does. I'm happy to leave this PR open whilst we figure out what you mean regarding the UI being out of date, but I'm not sure about this because the images seem to match the current experience. Are you able to take screenshots of your own experience so I can see if I'm missing something? Just to let you know: the best resolution may be to direct you to a Discussion or to our Support team, depending on the case. |
Hi @shadoath, if you don't have any notifications set up on https://github.com/settings/notifications to go to GitHub.com, then the icon won't appear for you. If you try flipping one of the toggles (eg "Subscriptions") to "On GitHub", then refresh, it should appear. Per the article:
|
I'm going to go ahead and close this out as there isn't a UI issue. Feel free to check out our issues marked |
Thank you, that was the missing piece for me. |
Add link to the Custom Routing URL.
Why:
Shorten the path to reaching the page needed.
Closes:
N/A
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.