Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop redundant polyfills #37

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

keithamus
Copy link
Member

This drops the following polyfills from the codebase:

  • AggregateError - supported in Safari 14+, Firefox ESR+, and Serenity LadyBird.
  • Promise.allSettled - supported in Safari 13+, Firefox ESR+, and Serenity LadyBird.
  • Promise.any - supported in Safari 14+, Firefox ESR+, and Serenity LadyBird.
  • Element.prototype.replaceChildren - supported in Safari 14+, Firefox ESR+, and Serenity LadyBird
  • String.prototype.replaceAll - supported in Safari 13.1+, Firefox ESR+, and Serenity LadyBird

Given how we think about browsers, these polyfills are not required for the vast majority of our traffic:

AggregateError

Browser Supported Since Latest Version % Supported % Unsupported
chrome 85 101 70.773 0.075
edge 85 100 9.448 0.004
firefox 79 100 12.343 0.020
firefox_android 79 100 0.262 0.000
ie Not Supported 11 0.000 0.008
opera 71 86 1.567 0.000
safari 14 15.4 3.979 0.021
safari_ios 14 15.4 1.086 0.044
samsunginternet_android 14.0 16.0 0.089 0.000
webview_android 85 101 0.007 0.021
Total: 99.554 0.193

Promise.allSettled

Browser Supported Since Latest Version % Supported % Unsupported
chrome 76 101 70.807 0.041
edge 79 100 9.450 0.003
firefox 71 100 12.356 0.007
firefox_android 79 100 0.262 0.000
ie Not Supported 11 0.000 0.008
opera 63 86 1.567 0.000
safari 13 15.4 3.990 0.010
safari_ios 13 15.4 1.091 0.039
samsunginternet_android 12.0 16.0 0.089 0.000
webview_android 76 101 0.008 0.021
Total: 99.62 0.129

Promise.any

Browser Supported Since Latest Version % Supported % Unsupported
chrome 85 101 70.773 0.075
edge 85 100 9.448 0.004
firefox 79 100 12.343 0.020
firefox_android 79 100 0.262 0.000
ie Not Supported 11 0.000 0.008
opera 71 86 1.567 0.000
safari 14 15.4 3.979 0.021
safari_ios 14 15.4 1.086 0.044
samsunginternet_android 14.0 16.0 0.089 0.000
webview_android 85 101 0.007 0.021
Total: 99.554 0.193

Element.prototype.replaceChildren

Browser Supported Since Latest Version % Supported % Unsupported
chrome 86 101 70.687 0.160
edge 86 100 9.448 0.005
firefox 78 100 12.355 0.008
firefox_android 79 100 0.262 0.000
ie Not Supported 11 0.000 0.008
opera 72 86 1.567 0.000
safari 14 15.4 3.979 0.021
safari_ios 14 15.4 1.086 0.044
samsunginternet_android 14.0 16.0 0.089 0.000
webview_android 86 101 0.007 0.021
Total: 99.48 0.267

String.prototype.replaceAll

Browser Supported Since Latest Version % Supported % Unsupported
chrome 85 101 70.773 0.075
edge 85 100 9.448 0.004
firefox 77 100 12.355 0.008
firefox_android 79 100 0.262 0.000
ie Not Supported 11 0.000 0.008
opera 71 86 1.567 0.000
safari 13.1 15.4 3.990 0.010
safari_ios 13.4 15.4 1.088 0.042
samsunginternet_android 14.0 16.0 0.089 0.000
webview_android 85 101 0.007 0.021
Total: 99.579 0.168

@jfuchs
Copy link

jfuchs commented Aug 14, 2023

@keithamus hi! is this ready for review?

@keithamus keithamus marked this pull request as ready for review August 15, 2023 08:44
@keithamus keithamus requested a review from a team as a code owner August 15, 2023 08:44
@keithamus keithamus requested a review from jfuchs August 15, 2023 08:44
@keithamus
Copy link
Member Author

Sure, it can be. This is a BREAKING change. We could wait until September when Safari 17 is likely to be released.

@dgreif
Copy link
Contributor

dgreif commented Oct 6, 2023

👋 hello from October 😄. Looks like Safari 17 is out, so we should be ready to officially drop Safari 13/14 🔥. @keithamus would you mind fixing up the conflicts on this? Or I can take a look as FR next week if you are busy on other projects

@keithamus
Copy link
Member Author

Between passion week this week and ActionMenu work next week I might not get round to it, but I'll try to, unless you beat me to it 😉

BREAKING CHANGE
@keithamus keithamus merged commit 8a87ec7 into github:main Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants