-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GMPrakhar,
Congrats on graduating! 🎓 🎉
Unfortunately, the image is not squared (1:1 or width = height) 🔳 The size of the image is 1387x1467 (pixels). Could you please make this change? 📝
Thanks,
Mohammed Shoaib
I have updated the PR, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GMPrakhar,
Thanks for resizing the image! Your pull request looks good 👌
I confirm the following is correct:
- Checklist is complete. ✔️
- Pull request only modified submission files (2 files) 📂
- Profile picture is squared and has at least 544 pixels 🔳
I wish you all the best in your future endeavors! 🦄
Best,
Mohammed Shoaib
Thanks Shoaib! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have reviewed 📝 your application to the yearbook. It looks great ✨ but we found that some headers might be missing in the Markdown file or the format is broken (used any non-ascii characters?). I will close this PR so you can do the changes requested. You can open a new one once you've done the fixes and we will review it again.😊
@GMPrakhar Pretty sure the issue is with the quotes. I didn't expect single quotes to cause a problem but thought double quotes were an issue as mentioned in #2321. Could you please remove them and make a new PR? Thanks, |
Application to the Class of 2020🎓
This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.
Checklist ✅
_data
folder and followed the naming convention mentioned in the instructions (<username>
), added my profile picture and markdown file.