Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Prakhar Londhe's Pull request #4353

Closed
wants to merge 4 commits into from

Conversation

GMPrakhar
Copy link
Contributor

@GMPrakhar GMPrakhar commented Jun 7, 2020

Application to the Class of 2020🎓

This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.

Checklist ✅

  • I have read the instructions on the README file before submitting my application.
  • I made my submission by creating a folder on the _data folder and followed the naming convention mentioned in the instructions (<username>), added my profile picture and markdown file.
  • I have used the Markdown file template to add my information to the Year Book.
  • I understand that a reviewer will merge my pull request after examining it or ask for changes in case needed.
  • I understand I should not tag or add a reviewer to this Pull Request.
  • I understand the photo added to the template will be used in the ceremony "Graduate Walk".
  • I have added the event to my Calendar.

Copy link
Contributor

@Mohammed-Shoaib Mohammed-Shoaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GMPrakhar,

Congrats on graduating! 🎓 🎉

Unfortunately, the image is not squared (1:1 or width = height) 🔳 The size of the image is 1387x1467 (pixels). Could you please make this change? 📝

Thanks,
Mohammed Shoaib

@GMPrakhar
Copy link
Contributor Author

I have updated the PR, please check.

Copy link
Contributor

@Mohammed-Shoaib Mohammed-Shoaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GMPrakhar,

Thanks for resizing the image! Your pull request looks good 👌

I confirm the following is correct:

  1. Checklist is complete. ✔️
  2. Pull request only modified submission files (2 files) 📂
  3. Profile picture is squared and has at least 544 pixels 🔳

I wish you all the best in your future endeavors! 🦄

Best,
Mohammed Shoaib

@GMPrakhar
Copy link
Contributor Author

Thanks Shoaib!

Copy link
Contributor

@juanpflores juanpflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have reviewed 📝 your application to the yearbook. It looks great ✨ but we found that some headers might be missing in the Markdown file or the format is broken (used any non-ascii characters?). I will close this PR so you can do the changes requested. You can open a new one once you've done the fixes and we will review it again.😊

@Mohammed-Shoaib
Copy link
Contributor

@GMPrakhar Pretty sure the issue is with the quotes. I didn't expect single quotes to cause a problem but thought double quotes were an issue as mentioned in #2321. Could you please remove them and make a new PR?

Thanks,
Mohammed Shoaib 🦄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants