Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix price fetching bug #3706

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix price fetching bug #3706

merged 1 commit into from
Oct 24, 2024

Conversation

0xKurt
Copy link
Member

@0xKurt 0xKurt commented Oct 24, 2024

fixes PAR-566

We have made the following updates:

  1. Checkout:
    • If price fetching fails for any reason, users will still be able to proceed with the checkout process.

_2. CUSD Token Update:

  • The Redstone token ID for CUSD has been updated in the chain data package.
  1. USDGLO Replacement:
    • Since USDGLO is not available on Redstone and accurate pricing is not critical in this context, we have replaced the Redstone token ID for USDGLO with CUSD. This ensures a similar approximation in price._

Action Item:

  • Discuss the handling of tokens that are not available on Redstone. Begin by identifying where Redstone is currently used and then determine the importance of accurate prices for these services.

@0xKurt 0xKurt requested review from a team as code owners October 24, 2024 08:48
Copy link

linear bot commented Oct 24, 2024

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am

Copy link
Member

@hussedev hussedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKurt 0xKurt merged commit 912c7fd into main Oct 24, 2024
13 of 14 checks passed
@0xKurt 0xKurt deleted the redstone-fix branch October 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants