fix: map embed urls and encode text (#3696)

gitcoinco · Oct 18, 2024 · a7110ae · a7110ae
1 parent 7ea61f7
commit a7110ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/grant-explorer/src/features/common/ShareButtons.tsx b/packages/grant-explorer/src/features/common/ShareButtons.tsx
@@ -106,7 +106,7 @@ export function createFarcasterShareUrl(
   embedLinks: string[]
 ) {
   // NB: embed links should not be encoded
-  return `https://warpcast.com/~/compose?text=${shareText}${embedLinks.forEach((link) => `&embeds[]=${link}`)}`;
+  return `https://warpcast.com/~/compose?text=${shareText}${embedLinks.map((link) => `&embeds[]=${link}`)}`;
 }
 
 type TwitterButtonParams = {

diff --git a/packages/grant-explorer/src/features/round/ViewRoundPage.tsx b/packages/grant-explorer/src/features/round/ViewRoundPage.tsx
@@ -1171,9 +1171,10 @@ const ShareButton = ({
     shareText + window.location.href
   )}`;
 
-  const farcasterShareUrl = createFarcasterShareUrl(shareText, [
-    window.location.href,
-  ]);
+  const farcasterShareUrl = createFarcasterShareUrl(
+    encodeURIComponent(shareText),
+    [window.location.href]
+  );
 
   return (
     <>