Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoC-2019-Ideas: don't split text within the `s #366

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

sivaraam
Copy link
Member

When the text within the ` (tildes) is split between two lines
it is not rendered as expected. To be precise the part that
comes in the second line isn't visible.

It's worth noting that this is not clear from the rendering
of the markdown by GitHub. But it's clear from the syntax
highlighting done by the editor in GitHub and the rendering
in the website (where this was first noted).

When the text within the ` (tildes)  is split between two lines
it is not rendered as expected. To be precise the part that
comes in the second line isn't visible.

It's worth noting that this is not clear from the rendering
of the markdown by GitHub. But it's clear from the syntax
highlighting done by the editor in GitHub and the rendering
in the website (where this was first noted).
@chriscool chriscool merged commit 28040df into git:master Mar 10, 2019
@chriscool
Copy link
Collaborator

Thanks again!

@sivaraam
Copy link
Member Author

You're welcome! 😄

Actually, I also noticed another issue which I was thinking of fixing but couldn't find how to fix it. The issue is that the code block in the "git log --oneline improvements" section renders badly in smaller screen. Further it also breaks the single-pagedness of the website. As a consequence, one might have to zoom in to read the post and scrolling might take you to empty space in the right. Screen shots:

  • Desktop view:
    Screenshot from 2019-03-10 20-56-49

  • Mobile view (iPhone SE resolution)
    Screenshot from 2019-03-10 20-56-14

    Screenshot from 2019-03-10 21-03-46

    Note the scroll bar in the bottom of the page.

Are you aware of any possible way to fix this? I was thinking that a fix should make the code block alone to be scrollable rather than the whole page.

@chriscool
Copy link
Collaborator

No, I am not aware about how we could fix it. It would be nice though if you could copy everything about it into a new issue, so that we could be reminded that this issue exists and maybe fix it one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants