Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep sidebar open when clicking inside it #1917

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Keep sidebar open when clicking inside it #1917

merged 1 commit into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. Keep sidebar open when clicking inside it 

    The "sidebar menu" is implemented via two <div>s, one acting as the
button (`.sidebar-btn`), the other as the menu (`.sidebar`).

The menu is shown by virtue of a `.sidebar-btn:focus + .sidebar` rule
that sets the `transform` attribute to 0 (it defaults to -105.5%).

The big problem with this design is that clicking inside the sidebar
menu transfers focus away from the button, and the sidebar menu
vanishes. Typically without following the link that the viewer clicked,
as reported in git#1916.

Let's let the sidebar menu be shown also when the focus is within said
menu, via the `:focus-within` pseudo-class (for more details, see
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-within), which
is supported reasonably widely by browsers.

Signed-off-by: Johannes Schindelin <[email protected]>
    @dscho
    dscho committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7991fa4 View commit details
    Browse the repository at this point in the history