Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Asciidoctor extensions to regular Asciidoctor #84

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

dscho
Copy link
Member

@dscho dscho commented Jun 12, 2024

This PR ensures that the mingw-w64-asciidoctor-extensions package as well as the asciidoctor gem are uninstalled, and that the mingw-w64-asciidoctor package is installed instead. This PR is a companion of git-for-windows/MINGW-packages#119.

Here is a run (with one commit on top to trigger said run) that verifies that it does what I intend.

In git-for-windows/MINGW-packages#119, Git for
Windows switched away from the custom-built Asciidoctor extensions, now
instead using the regular Asciidoctor.

This patch is a companion of that PR to ensure that Git for Windows' SDK
is aligned with that change.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho requested a review from dennisameling June 12, 2024 17:32
@dscho dscho self-assigned this Jun 12, 2024
@dscho dscho force-pushed the git-sdk-64-github-workflows branch from 2e8c58b to 385936c Compare June 12, 2024 17:40
@dscho dscho merged commit 2367fb7 into git-for-windows:main Jun 17, 2024
20 checks passed
@dscho dscho deleted the git-sdk-64-github-workflows branch June 17, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants