-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Flow to Typescript #456 #475
Conversation
…lict with react-scripts
I saw the CI build failed, and it looks like it's due to a peer dependency conflict on the example site (react-scripts). Oddly enough I haven't seen that issue on my end, but to resolve it I have downgraded typescript to ^4 on the example site. I see that the Flow stage is stuck in status: "Expected — Waiting for status to be reported". This might be due to branch rules set on the repository. Since Flow is no longer in the workflow, it will need to be removed. |
@nateplusplus This is amazing, thank you! We'll take a look at this PR soon! |
Thanks for the work! |
Closes #456
This has been a fun challenge and a great TypeScript exercise! 😄
It would be great to get another pair of eyes on this work to ensure nothing was missed. This touches the entire library, so it is a pretty major change. I am happy to update any issues you find. I have also checked "Allow edits by maintainers" so feel free to add to my branch if necessary.
What was done:
TODO
comments (will also create separate issues for each)To test
npm i
to install dependencies in both the root folder andexample/
npm start
npm run test:ts
on the project root, andnpm run typescript
on the example site. Note: this will not emit any files, but will only check for errors.act()
but this is a pre-existing issue and not a result of the TypeScript changes.index.js
andindex.modern.mjs
as usual, however you will also notice extra TypeScript definition files, and those will be exported in a directory structure which matches thesrc
directory.