-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockgroup modifications #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris7
force-pushed
the
blockgroup-modifications
branch
from
October 30, 2024 16:53
6248a66
to
5507725
Compare
Chris7
force-pushed
the
blockgroup-modifications
branch
from
October 30, 2024 19:28
a498274
to
d9f6c62
Compare
Chris7
force-pushed
the
blockgroup-modifications
branch
from
October 31, 2024 13:32
d9f6c62
to
a4bd175
Compare
Merged
dkhofer
reviewed
Nov 1, 2024
Chris7
commented
Nov 1, 2024
dkhofer
reviewed
Nov 1, 2024
Mostly looks good, I'm still trying to understand some of the details, asked some questions in slack |
dkhofer
reviewed
Nov 5, 2024
I think I understand enough that I'm going to approve. One suggestion: I think |
dkhofer
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable modifications directly on blockgroups instead of paths to enable iterative engineering. I noticed on the gfa's we're exporting we need to fix how we're parsing deletions from vcfs (