Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockgroup modifications #79

Merged
merged 16 commits into from
Nov 5, 2024
Merged

Blockgroup modifications #79

merged 16 commits into from
Nov 5, 2024

Conversation

Chris7
Copy link
Collaborator

@Chris7 Chris7 commented Oct 29, 2024

Enable modifications directly on blockgroups instead of paths to enable iterative engineering. I noticed on the gfa's we're exporting we need to fix how we're parsing deletions from vcfs (

@Chris7 Chris7 changed the base branch from main to lineage-tracking October 29, 2024 18:52
@Chris7 Chris7 changed the base branch from lineage-tracking to main October 30, 2024 16:53
@Chris7 Chris7 mentioned this pull request Oct 31, 2024
@Chris7 Chris7 changed the title WIP: Blockgroup modifications Blockgroup modifications Nov 1, 2024
@Chris7 Chris7 requested a review from dkhofer November 1, 2024 13:53
src/models/block_group.rs Outdated Show resolved Hide resolved
src/imports/fasta.rs Outdated Show resolved Hide resolved
@dkhofer
Copy link
Collaborator

dkhofer commented Nov 1, 2024

Mostly looks good, I'm still trying to understand some of the details, asked some questions in slack

src/graph.rs Outdated Show resolved Hide resolved
@dkhofer
Copy link
Collaborator

dkhofer commented Nov 5, 2024

I think I understand enough that I'm going to approve.

One suggestion: I think prune_graph could be moved alongside build_graph in the Edge model, and prune could be a parameter to that method. Pretty much everywhere prune_graph is called, is right after build_graph in Edge or get_graph in BlockGroup

@Chris7 Chris7 merged commit c30c185 into main Nov 5, 2024
1 check passed
@Chris7 Chris7 deleted the blockgroup-modifications branch November 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants