Accession support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris7
commented
Oct 22, 2024
| @@ -1,9 +1,9 @@ | |||
| H VN:Z:1.2 | |||
There was a problem hiding this comment.
i changed this file to be the same sequence as simple.fa so we can use the same vcfs for both.
Chris7
force-pushed
the
accessions-vcf
branch
from
15b9034
to
620d3ff
Compare
dkhofer
reviewed
Oct 24, 2024
migrations/core/01-initial/up.sql
Outdated
| name TEXT NOT NULL, | ||
| -- path accessions can reference other path accessions | ||
| path_id INTEGER NOT NULL, | ||
| accession_id INTEGER, |
There was a problem hiding this comment.
Is there some way to name this to make it clearer why we're referencing another accession? parent_accession_id? previous_accession_id?
There was a problem hiding this comment.
sure, it's meant to be parent_accession_id -- idea is this accssion is nested in another.
dkhofer
reviewed
Oct 24, 2024
dkhofer
reviewed
Oct 24, 2024
dkhofer
reviewed
Oct 24, 2024
dkhofer
approved these changes
Oct 24, 2024
Chris7
force-pushed
the
accessions-vcf
branch
from
796bed2
to
2093f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new model type, accession, that lets users assign a name to a subsequence of a path. There's support in here for a convention to use in vcf files for specifying that a change should be given a particular accession.